Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Packed Weights #63

Merged
merged 6 commits into from
May 27, 2024
Merged

Rename Packed Weights #63

merged 6 commits into from
May 27, 2024

Conversation

Satrat
Copy link

@Satrat Satrat commented May 22, 2024

Fixes Reloading of packed int4 models into SparseML, without renaming the weight we get a shape error on reload with SparseAutoModel

Testing

Updated unit tests, confirmed reloading with a 1.1b model

@Satrat Satrat marked this pull request as ready for review May 22, 2024 20:56
@Satrat Satrat mentioned this pull request May 22, 2024
@Satrat Satrat requested review from bfineran and dsikka May 23, 2024 14:23
@Satrat Satrat changed the base branch from small_fixes to main May 23, 2024 14:36
dbogunowicz
dbogunowicz previously approved these changes May 23, 2024
bfineran
bfineran previously approved these changes May 23, 2024
@Satrat Satrat dismissed stale reviews from bfineran and dbogunowicz via 1694b0b May 23, 2024 17:25
@dbogunowicz
Copy link
Contributor

Taking the liberty to land this.

@dbogunowicz dbogunowicz merged commit 7354c4b into main May 27, 2024
1 check passed
@dbogunowicz dbogunowicz deleted the sa/weight_packed branch May 27, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants