Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding KNNClassificationDecider #463

Open
wants to merge 143 commits into
base: KNNDecider
Choose a base branch
from
Open

Adding KNNClassificationDecider #463

wants to merge 143 commits into from

Conversation

david-z-shi
Copy link
Contributor

Reference issue

Closes #461.

Type of change

Adding KNNClassificationDeciders.

What does this implement/fix?

Adding experiments for KNNClassificationDecider and the associated deciders for these experiments

Additional information

Experiments need more compute and reps.

david-z-shi and others added 30 commits September 18, 2020 17:33
@david-z-shi
Merge pull request #2 from neurodata/master
aa3ecf1 
0918 Merge
@david-z-shi
Merge remote-tracking branch 'upstream/master'
f48f6c2
@david-z-shi
Revert "Merge remote-tracking branch 'upstream/master'"
7b7c0b8 
This reverts commit f48f6c2, reversing
changes made to aa3ecf1.
@david-z-shi
Revert "Revert "Merge remote-tracking branch 'upstream/master'""
f6d4784 
This reverts commit 7b7c0b8.
@david-z-shi
Merge pull request #3 from neurodata/main
6db1ecc 
update fork
@david-z-shi
Merge pull request #4 from neurodata/main
c15299c 
updated with main repo 10/27/2020
@parthgvora
staging branch finally
660eab2
@parthgvora
all tests pass
273f960
finished documentation
fb8cb0f
fixed some bugs and finished predict tests
c4cef8b
@parthgvora
Fixed header, unnecessary imports
2481e91
@parthgvora
Including oblique_tree in proglearn
cf1b017
@parthgvora
fixing importing issues
83c9f13
@parthgvora
black formatting
a7c31f0
@PSSF23
Fix docstring indents
0e50784
@parthgvora
black formatting
1328b75
@parthgvora
Merge branch 'staging' of https://github.com/parthgvora/ProgLearn int…
7f876fe 
…o staging
@parthgvora
oblique trees added
ecb7b07
@parthgvora
consistency of default params
39cf94a
made some documentation changes and created decision boundaries notebook
df391b6
@PSSF23 @jmandavilli @parthgvora
Update tutorials.rst
8224304 
Co-Authored-By: jmandav1 <39231283+jmandavilli@users.noreply.github.com>
Co-Authored-By: parthgvora <parthgvora@gmail.com>
@PSSF23
Merge branch 'staging' into staging
395dc9e
@ypeng22
ConvRF Experiments
3d7c50a
@PSSF23 @ypeng22
Remove duplicate and unused function
2d774b7 
Co-Authored-By: ypeng22 <68977380+ypeng22@users.noreply.github.com>
renamed notebooks
cf93af4
@PSSF23 @jmandavilli @parthgvora
Update and rename oblique_decision_boundaries_functions.py to sporf_d…
706ef42 
…ecision_boundaries_functions.py

Co-Authored-By: jmandav1 <39231283+jmandavilli@users.noreply.github.com>
Co-Authored-By: parthgvora <parthgvora@gmail.com>
@PSSF23 @jmandavilli @parthgvora
Rename function for consistency
6e1205e 
Co-Authored-By: jmandav1 <39231283+jmandavilli@users.noreply.github.com>
Co-Authored-By: parthgvora <parthgvora@gmail.com>
@levinwil
Merge pull request neurodata#374 from parthgvora/staging
df734df 
Implement SPORF
@emilyachang
fte/bte mnist added
faadd4c
@hhelm10
Make the array-ness of self.classes explicit
bedafd2 
Indexing into a list using an array of integers does not work and for some reason in my use case that's what self.classes is. This simply makes the array-ness of self.classes explicit.
bstraus1 and others added 18 commits February 8, 2021 17:16
@bstraus1
Merge pull request #1 from neurodata/staging
7cfbffd 
Pulled updates from Staging
@bstraus1
Added overview section to the Proglearn documentation
8a6cddb 
Add an overview section (as in the [Verde](https://www.fatiando.org/verde/latest/tutorials/overview.html) documentation)
@bstraus1
Merge branch 'staging' of https://github.com/bstraus1/ProgLearn into …
ff11449 
…staging
@PSSF23
Update DOI badge to cite all versions
bc07482
@PSSF23
Update DOI badge to cite all versions
4048ff0
@PSSF23
Change terms for adding the overview section
308ddef
@PSSF23
Optimize style and remove unnecessary section
0f41b40
@PSSF23
Merge pull request neurodata#441 from bstraus1/staging
0fb86e8 
Add an overview section to the ProgLearn documentation
@jdey4
Merge pull request neurodata#440 from PSSF23/smooth_criminal
d4e8bc2 
Optimize reference page and DOI badge
@david-z-shi
Merge branch 'master' into KNNDecider
6081fad
@david-z-shi
Merge branch 'xor_rxor_KNN' into KNNDecider
9904ff8
@david-z-shi
first experiments with KNN
59042b7
@david-z-shi
update with not working experiment
22670df
@david-z-shi
testing experiments
3906f75
@david-z-shi
updated with simpler KNN implementation
5e01841
@david-z-shi
update experiments with KNNClassification settings and KNNRegression …
75fc321 
…visualizations
@david-z-shi
update with some trial experiments
150bfbc
@david-z-shi
update with experiments
85f3396
@david-z-shi
Copy link
Contributor Author

@jdey4 Let me know if I need to make any other changes.

@PSSF23 PSSF23 requested a review from jdey4 May 3, 2021 20:11
PSSF23
PSSF23 reviewed May 3, 2021
View reviewed changes
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the KNN branch is pretty outdated, so I would suggest not closing your issue by this PR. @jdey4 Perhaps we can merge this one and then merge KNNDecider to staging? Or should the branches stay separated?

PSSF23
PSSF23 reviewed May 3, 2021
View reviewed changes
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@latasianguy And I see that the black check failed. Check the log and format your code~

PSSF23
PSSF23 reviewed May 3, 2021
View reviewed changes
Copy link
Member

@PSSF23 PSSF23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@latasianguy It's too hard to locate where you exactly changed. Could you make a list of any "new" files you added in this PR?

@david-z-shi
Copy link
Contributor Author

Yep, everything here and here is new, and there are additional transformers, voters, and deciders in here.

@PSSF23 PSSF23 requested review from sampan501 and eigenvivek May 6, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PSSF23 PSSF23 PSSF23 left review comments

@jdey4 jdey4 Awaiting requested review from jdey4

@sampan501 sampan501 Awaiting requested review from sampan501

@eigenvivek eigenvivek Awaiting requested review from eigenvivek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@david-z-shi @PSSF23 @parthgvora @ypeng22 @levinwil @emilyachang @hhelm10 @EYezerets @jdey4 @bstraus1