Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT Fix builder partial fit #62

Merged
merged 10 commits into from
Apr 2, 2024
Merged

MAINT Fix builder partial fit #62

merged 10 commits into from
Apr 2, 2024

Conversation

adam2392
Copy link
Collaborator

Reference Issues/PRs

Fixes state of builder_ to not need to be maintained.

Prolly needs unit-tests to determine if this "functions as desired". I.e.

  • changing datatype of X over multiple partial fits should fail nicely,
  • changing datatype of y
  • classification and regression

What does this implement/fix? Explain your changes.

Any other comments?

Signed-off-by: Adam Li <adam2392@gmail.com>
Copy link

github-actions bot commented Mar 29, 2024

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 39bdda9. Link to the linter CI: here

Signed-off-by: Adam Li <adam2392@gmail.com>
adam2392 added 8 commits April 2, 2024 17:15
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392 adam2392 merged commit e020253 into submodulev3 Apr 2, 2024
4 of 6 checks passed
@adam2392 adam2392 deleted the partialrefactor branch April 2, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant