-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR of individual commits to fix small issues. #314
Conversation
394364c
to
6d4c018
Compare
f09af86
to
dff1a25
Compare
d3b6b35
to
f47921a
Compare
f47921a
to
441140a
Compare
f0795e9
to
81eeaa4
Compare
d9b2e99
to
989b5ed
Compare
d118647
to
b66f601
Compare
…tree test in CLI tests.
b66f601
to
598fd67
Compare
598fd67
to
5c4eba1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @JoeZiminski ! I reviewed this by commit, as suggested
@niksirbi how did things go in the end with the NIU test action, can I help with anything? I took the lazy way and revereted back to not using for now :'D
We kinda found a functional workaround for movement
which allows us to keep using the NIU test action as is.
Basically what we do is the following:
- in the workflow we setup conda before we call the NIU test action.
- In
pyproject.toml
we configuretox-conda
to installpytables
in the test environment (fordatashuttle
that would berclone
).
The problem was that tox-conda
could not find the conda executable on some OSes (macos-14 and windows), but setting up and activating conda before the tests seems to have taken care of that.
Maybe worth a try for datashuttle
as well?
This PR makes many small fixes to issues that have come up over time. It should be considered as a holding PR for many separate individual issues, which can be considered separately. This should be normal merged (not squash merged) and can be reveiwed by commit. All changes are linked to existing issues:
tui
(intui
tests) #302Popen
rather rthanrun
was used to make CLI calls, inadvertantly creating and not closing many processes! d1bc9cc@niksirbi how did things go in the end with the NIU test action, can I help with anything? I took the lazy way and revereted back to not using for now :'D BTW apologies I did set you as rewiere previously and it was not ready to review - it is now.