Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop supporting python3.8 #42

Closed
niksirbi opened this issue Sep 14, 2023 · 7 comments
Closed

Stop supporting python3.8 #42

niksirbi opened this issue Sep 14, 2023 · 7 comments
Assignees
Labels
enhancement New optional feature

Comments

@niksirbi
Copy link
Member

Python 3.9 introduced type hinting generics in standard collections via PEP 585.
This allows us to directly use the usual Python collection types (eg list, dict) as type hints, instead of using typing.List and typing.Dict. Moreover, even though typing collections still work as type hints on newer Python versions, they are being deprecated.
The solution is to get rid of Python 3.8, the active support of which has already ended (with security support ending in ~1 year, see endoflife.data).

@niksirbi niksirbi added the enhancement New optional feature label Sep 14, 2023
@niksirbi niksirbi self-assigned this Sep 14, 2023
@niksirbi
Copy link
Member Author

Issue was raised by @lochhh while reviewing PR #33.

@niksirbi niksirbi mentioned this issue Sep 14, 2023
@lochhh
Copy link
Collaborator

lochhh commented Sep 14, 2023

We would still need typing.Optional and typing.Union in load_poses.py with 3.9, since the | syntax is only supported 3.10 onwards.

@niksirbi
Copy link
Member Author

Hm, that's annoying, it's too early to get rid of Python 3.9 yet. We have to tolerate typing.Optional and typing.Union for now.
But we can still get rid of Python3.8 and start using the "usual" collections in type hints. Solving half the problem is still worth it?

@lochhh
Copy link
Collaborator

lochhh commented Sep 14, 2023

Yep definitely stick with 3.9+ for now - can imagine other dependencies still requiring at least 3.9

@adamltyson
Copy link
Member

Yep definitely stick with 3.9+ for now - can imagine other dependencies still requiring at least 3.9

I'm keen to stick to NEP29 where we can.

@niksirbi niksirbi assigned DhruvSkyy and unassigned niksirbi Sep 20, 2023
@niksirbi
Copy link
Member Author

@DhruvSkyy has kindly volunteered to have a shot at this one 🍾

@niksirbi
Copy link
Member Author

closed via #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New optional feature
Projects
Development

No branches or pull requests

4 participants