Deprecate support for python 3.8 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage 97.74% 97.74%
=======================================
Files 8 8
Lines 310 310
=======================================
Hits 303 303
Misses 7 7
☔ View full report in Codecov by Sentry. |
niksirbi
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
Great work @DhruvSkyy !
Congrats on getting your first PR approved 🍾 !!
I will merge this as is.
My only pedantic quibble is to use more informative names for branches in the future. For example, something like remove-python38 is what I would probably use as a branch name here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.9 introduced type hinting generics in standard collections via PEP 585.
Replaced typing.list to list for datasets.py and validators.py.
Also changed typing.collections to collections.abc.Iterable for validators.py.
Did not remove typing.Optional, typing.Union, typing.Any, typing.Literal and typing.ClassVar as these were not mentioned to be deprecated on https://peps.python.org/pep-0585/.
Removed support for Python 3.8 from the following files: