Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration tests #295

Merged
merged 17 commits into from
Oct 17, 2024
Merged

Update integration tests #295

merged 17 commits into from
Oct 17, 2024

Conversation

sfmig
Copy link
Contributor

@sfmig sfmig commented Aug 30, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
Updates integration tests to match recent changes to kinematic tests. Also simplifies one of the integration tests and factors part of it out as a unit test.

What does this PR do?

  • Modifies test_cart2pol_transform_on_kinematics to better match the current kinematic tests (mainly to use datasets with easily derivable kinematics).
  • Split test_nan_propagation_through_filters into two tests:
    • an integration test that runs filter by confidence, SG filter and interpolation sequentially, and
    • a unit test (test_filter_with_nans_on_position_varying_window) that counts the number of nans stays below the expected upper bound when applying a median filter or SG filter.

References

Please reference any existing issues/PRs that relate to this PR.

How has this PR been tested?

Please explain how any new code has been tested, and how you have ensured that no existing functionality has changed.

Is this a breaking change?

If this PR breaks any existing functionality, please explain how and why.

Does this PR require an update to the documentation?

If any features have changed, or have been added. Please explain how the
documentation has been updated.

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

Copy link

codecov bot commented Aug 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.77%. Comparing base (bfb20d2) to head (e947f6c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage   99.77%   99.77%           
=======================================
  Files          15       15           
  Lines         909      909           
=======================================
  Hits          907      907           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig marked this pull request as ready for review September 16, 2024 17:48
@sfmig sfmig requested a review from niksirbi September 16, 2024 17:53
Copy link
Member

@niksirbi niksirbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @sfmig! I am onboard with all the changes, nothing to comment. LGTM!

@sfmig sfmig added this pull request to the merge queue Oct 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 17, 2024
@sfmig sfmig force-pushed the smg/integration-filtering-tests branch from c406952 to 1e03f0f Compare October 17, 2024 10:11
@niksirbi niksirbi mentioned this pull request Oct 17, 2024
14 tasks
Copy link

sonarcloud bot commented Oct 17, 2024

@sfmig sfmig enabled auto-merge October 17, 2024 11:32
@sfmig sfmig added this pull request to the merge queue Oct 17, 2024
Merged via the queue into main with commit a42838d Oct 17, 2024
17 checks passed
@sfmig sfmig deleted the smg/integration-filtering-tests branch October 17, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants