-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import dlc tracks #9
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #9 +/- ##
=======================================
Coverage ? 96.29%
=======================================
Files ? 4
Lines ? 81
Branches ? 0
=======================================
Hits ? 78
Misses ? 3
Partials ? 0 |
I like to see the console as well (as a developer), but I think you are right about the users. I turned it off by default but added a |
Yes, I am aware of that and was planning to take care of it later, since I plan to store the data into a custom object anyway. However, I might as well write a convenience function now, converting from the csv-imported to the h5-imported version. |
I have now also added a conversion from the CSV-imported table to the h5-imported one, so both types of files now return the same dataframe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played around with the logging behaviour and all looks good to me:
- If I use
movement
, then the logs end up in~/.movement
- if I use
movement
within another package with logging, thenmovement
logs end up in the normal movement log, and the package log, but all other calls tologging
only go to the package log.
This is what I'd expect, and I think what we should do with all of these packages.
I made some small suggestions.
Co-authored-by: Adam Tyson <adam.tyson@ucl.ac.uk>
…cs-unit/movement into import-DLC-tracks
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
In the end, I purged the |
In this PR I implement a function for loading
deeplabcut
pose estimation data from an.h5
or a.csv
file.The data is currently imported in a
pd.DataFrame
object, but in future PR the tracks will be saved in a customTrajectory
class (see #12 ).This PR contains the first implemented feature, so alongside it, I have added:
pydantic