Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref output misses SliceTiming? #4

Closed
yarikoptic opened this issue Jun 23, 2017 · 2 comments
Closed

ref output misses SliceTiming? #4

yarikoptic opened this issue Jun 23, 2017 · 2 comments

Comments

@yarikoptic
Copy link
Collaborator

"testing" fresh release of dcm2niix v1.0.20170621 and it shows diffs like

diff -br -I ConversionSoftwareVersion /home/yoh/deb/gits/pkg-exppsy/dcm_qa/Out/6_8_PF_no_iPAT_2.json /home/yoh/deb/gits/pkg-exppsy/dcm_qa/Ref/6_8_PF_no_iPAT_2.json
27,63d26
<       "SliceTiming": [
<               1.255,
<               0,
<               1.325,
<               0.07,
<               1.395,
<               0.14,
...
@dangom
Copy link
Collaborator

dangom commented Jun 23, 2017 •
edited
Loading

Wow, that's funny. Doesn't happen here.
I tried both under MacOS and CentOS.

Could it be that your diff doesn't accept the -b flag?

neurolabusc added a commit to rordenlab/dcm2niix that referenced this issue Jun 23, 2017
@neurolabusc
[Ensure slice timing always encoded for Siemens EPI](neurolabusc/dcm_…
8061f16 
…qa#4 (comment))
@neurolabusc
Copy link
Owner

Well spotted. I have released a new version of dcm2niix (v1.0.20170623) that should consistently report slice timings for all systems and input datasets. I will generate new Ref images shortly. Nice example of how this validator can be useful.

neurolabusc added a commit that referenced this issue Jun 23, 2017
@neurolabusc
Update for #4
cd1bfe7
yarikoptic added a commit to neurodebian/dcm2niix that referenced this issue Aug 30, 2017
@yarikoptic
Merge tag 'v1.0.20170623' into debian
3fa5d7d 
* tag 'v1.0.20170623':
  [Ensure slice timing always encoded for Siemens EPI](neurolabusc/dcm_qa#4 (comment))
  Update COMPILE.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yarikoptic @dangom @neurolabusc