Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡ Replace archiver with zip-lib #276

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

CosmoMyzrailGorynych
Copy link
Contributor

Closes #275.
TL;DR: Allow using neu build with Bun as node.js package runner.

Observed side effects:

  1. Zipping an empty neutralino app (made by neu create sausage) is roughly twice as faster. Good!
Before/After Before:


After:
  1. The zip file is a smidgen larger. (5 230 417 --> 5 247 436 bytes.) This is due to zip-lib not having any compression options you can change.

Copy link
Member

@shalithasuranga shalithasuranga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for sending this pull-request @CosmoMyzrailGorynych The zip-lib module looks great 🎉

@shalithasuranga shalithasuranga merged commit 271e535 into neutralinojs:main Aug 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

neu build hangs up when run with bun
2 participants