This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add webpack-dev-server to web-relevant presets' peerDependencies #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
approved these changes
Sep 20, 2018
There was a problem hiding this comment.
When adding webpack-cli to peerDeps last week (after webpack-command was deprecated) I checked to see if webpack-serve was still active (since a peerDep would mean locking people into only one of the options) - which it was.
However it seems that as of two days ago, webpack-serve has been deprecated too:
webpack-contrib/webpack-serve@edaf28c
Simpler for us, and means we can now add the peerDep 👍
|
🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.