Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

dev-server: Remove redundant 'open' option #1168

Merged
merged 1 commit into from
Oct 11, 2018
Merged

dev-server: Remove redundant 'open' option #1168

merged 1 commit into from
Oct 11, 2018

Conversation

edmorley
Copy link
Member

Since webpack-dev-server already defaults open to false.

Note: Independent of this change, for projects created using create-project, we put --open in the start script command, see:
#1135 (comment)

Since `webpack-dev-server` already defaults `open` to `false`.

Note: Independent of this change, for projects created using
create-project, we put `--open` in the `start` script command, see:
#1135 (comment)
@edmorley edmorley added this to the v9 milestone Oct 11, 2018
@edmorley edmorley self-assigned this Oct 11, 2018
Copy link
Contributor

@timkelty timkelty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edmorley edmorley merged commit af898b0 into neutrinojs:master Oct 11, 2018
@edmorley edmorley deleted the devserver-rm-open-false branch October 11, 2018 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants