This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
create-project: Display lint command output when using --debug #1265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the stdout/stderr of the "initial lint" step was not shown as expected when `--debug` had been passed to `create-project`. Now the full console output is displayed inline, like was already the case for the package install steps. The yeoman `spawnCommandSync()` options have also been refactored to reduce duplication, and the error handling adjusted so that: - a user friendly message is still shown in the case of `result.error` - the suggestion to use `--debug` is not shown if it was already passed - there is no longer a verbose Neutrino stack trace shown See: https://yeoman.github.io/generator/Generator.html#spawnCommandSync https://nodejs.org/api/child_process.html#child_process_child_process_spawnsync_command_args_options Fixes #1262.
eliperelman
approved these changes
Dec 19, 2018
timkelty
pushed a commit
to timkelty/neutrino
that referenced
this pull request
Dec 19, 2018
…inojs#1265) Previously the stdout/stderr of the "initial lint" step was not shown as expected when `--debug` had been passed to `create-project`. Now the full console output is displayed inline, like was already the case for the package install steps. The yeoman `spawnCommandSync()` options have also been refactored to reduce duplication, and the error handling adjusted so that: - a user friendly message is still shown in the case of `result.error` - the suggestion to use `--debug` is not shown if it was already passed - there is no longer a verbose Neutrino stack trace shown See: https://yeoman.github.io/generator/Generator.html#spawnCommandSync https://nodejs.org/api/child_process.html#child_process_child_process_spawnsync_command_args_options Fixes neutrinojs#1262.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the stdout/stderr of the "initial lint" step was not shown as expected when
--debughad been passed tocreate-project. Now the full console output is displayed inline, like was already the case for the package install steps.The yeoman
spawnCommandSync()options have also been refactored to reduce duplication, and the error handling adjusted so that:result.error--debugis not shown if it was already passedSee:
https://yeoman.github.io/generator/Generator.html#spawnCommandSync
https://nodejs.org/api/child_process.html#child_process_child_process_spawnsync_command_args_options
Fixes #1262.