This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Update eslint-config-standard and switch from -jsx to -react #1465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the ESLint standardjs presets to latest, and switches from `eslint-config-standard-jsx` to `eslint-config-standard-react`, since the latter is a superset of the former and required for full React support. The new configs set the React version and plugins for us, so we no longer need to set them ourselves. Fixes #1449 and fixes #1450.
|
@neutrinojs/core-contributors? :-) |
|
@edmorley I'll take a look this morning! |
|
@timkelty? :-) |
|
Whoops, thanks for the nudge. Looking now! |
|
Thank you :-) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the ESLint standardjs presets to latest, and switches from
eslint-config-standard-jsxtoeslint-config-standard-react, since the latter is a superset of the former and required for full React support.The new configs set the React version and plugins for us, so we no longer need to set them ourselves.
Fixes #1449 and fixes #1450.