Upgrading Webpack to v3, merge config as middleware #315

eliperelman · 2017-09-12T19:47:05Z

No description provided.

…middleware

…onments

edmorley · 2017-09-28T16:10:42Z

Could you hold off releasing the new version until someone does a review pass? :-)

edmorley

Some awesome changes here! Can't wait to try webpack 3 with Treeherder and see what improvement it makes to build times. A few of the other fixes here will also mean fewer workarounds/even less boilerplate in the soon to be landing treeherder .neutrinorc.js :-)

edmorley · 2017-09-29T01:40:26Z

docs/presets/neutrino-preset-web/README.md

 | `compile` | Compiles JS files from the `src` directory using Babel. Contains a single loader named `babel`. From `neutrino-middleware-compile-loader`. | all |
-| `html` | Allows importing HTML files from modules. Contains a single loader named `html`. From `neutrino-middleware-html-loader`. | all |
+| `html` | Allows importing HTML files from modules. Contains a single loader named `file`. From `neutrino-middleware-html-loader`. | all |


I think this is an accidental revert of part of my changes from #325 which occurred when master was merged into this PR. I'll open a PR to reapply those changes :-)

This and the other docs parts fixed in #335

edmorley · 2017-09-29T01:40:45Z

docs/presets/neutrino-preset-web/README.md

@@ -280,21 +281,22 @@ The following is a list of plugins and their identifiers which can be overridden

 _Note: Some plugins are only available in certain environments. To override them, they should be modified conditionally._

-| Name | Description | Environments |
-| ---- | ----------- | ------------ |
+### Override configuration


edmorley · 2017-09-29T01:44:03Z

docs/upgrading-neutrino.md

+- **BREAKING CHANGE** ESLint has been upgraded to v4, which may bring linting configuration
+changes.
+- **BREAKING CHANGE** The Neutrino `static` option has been removed. The Web, React, and Node.js presets will
+still copy files from a `src/static` directory if it exists, but you can override your own


Is the plan to eventually remove this copying from src/static entirely? (The removal of the section mentioning it from project-layout.md just made me think this might be the case?).

I think copying from src/static is fine by default, but any overrides of copy would obviously negate that. What wasn't sustainable was providing an option for the static directory, since it just wasn't powerful enough or didn't operate as expected.

edmorley · 2017-09-29T01:49:18Z

docs/presets/neutrino-preset-karma/README.md

 16 02 2017 10:36:34.715:INFO [launcher]: Launching browser Chrome with unlimited concurrency
 16 02 2017 10:36:34.731:INFO [launcher]: Starting browser Chrome
-16 02 2017 10:36:35.655:INFO [Chrome 56.0.2924 (Mac OS X 10.12.3)]: Connected on socket MkTbqJLpAAa2HFaeAAAA with id 21326158
+16 02 2017 10:36:35.655:INFO [Chrome 60 (Mac OS X 10.12.3)]: Connected on socket MkTbqJLpAAa2HFaeAAAA with id 21326158


These changes and a few others need syncing to packages/* - I'll include them in the same PR as above :-)

edmorley · 2017-09-29T01:53:35Z

packages/neutrino-preset-web/README.md

@@ -12,14 +12,14 @@
 - Automatic creation of HTML pages, no templating necessary
 - Hot Module Replacement support
 - Tree-shaking to create smaller bundles
- Production-optimized bundles with Babili minification and easy chunking
+- Production-optimized bundles with Babili minification, easy chunking, and scope-hoisted modules for faster execution


This needs syncing to the docs/presets/* copies, plus to the react preset "includes from web" list

edmorley · 2017-09-29T01:56:16Z

.travis.yml

@@ -9,7 +9,7 @@ install:
 - yarn install --frozen-lockfile
 before_install:
 # Required due to: https://github.com/travis-ci/travis-ci/issues/7951
- curl -sSfL https://yarnpkg.com/install.sh | bash
+- curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 0.25.4


I see you've filed guigrpa/oao#50 for issues with oao on newer yarn. Perhaps it's worth adding a link to that here?

Yeah, good idea.

edmorley · 2017-09-29T02:07:14Z

docs/middleware/neutrino-middleware-minify/README.md

-The `babili` and `overrides` properties map to the options defined by
-[babili-webpack-plugin](https://www.npmjs.com/package/babili-webpack-plugin#options).
+The `minify` and `plugin` properties map to the options defined by
+[babel-minify-webpack-plugin](https://www.npmjs.com/package/babel-minify-webpack-plugin#options).


The #options anchor tag doesn't appear to work on the NPM package page. Perhaps we should link to https://github.com/webpack-contrib/babel-minify-webpack-plugin#options instead?

I'm cool with doing that.

Fixed in #340

edmorley · 2017-09-29T02:08:12Z

docs/presets/neutrino-preset-jest/README.md

-You can pass any additional option Jest accepts. See the [Jest documentation](https://facebook.github.io/jest/docs/configuration.html#collectcoveragefrom-array) for more configuration options.
+You can pass any additional option Jest accepts. See the
+[Jest documentation](https://facebook.github.io/jest/docs/configuration.html#collectcoveragefrom-array) for more
+configuration options.


This needs syncing to packages/*

edmorley · 2017-09-29T02:29:49Z

packages/neutrino-middleware-eslint/index.js

  const options = merge.all([
    opts,
-    !opts.include && !opts.exclude ? { include: [neutrino.options.source], exclude: [neutrino.options.static] } : {}
+    !opts.include && !opts.exclude ? { include: [neutrino.options.source] } : {}


Should this now be:
!opts.include ? { include: [neutrino.options.source] } : {}

This would allow people to specify an exclude list, but keep the default include, saving having to pass it unnecessarily (Treeherder hits this case for example).

Yeah, good catch.

edmorley · 2017-09-29T02:33:47Z

packages/neutrino-middleware-image-loader/index.js

@@ -3,18 +3,17 @@ const merge = require('deepmerge');
 module.exports = ({ config }, options = {}) => {
  const { limit } = merge({ limit: 8192 }, options);


I'm not sure if this is expected (ie to prevent the presets being overwhelmed with options), but none of the presets actually pass in any options to this or some of the other middleware - so this functionality is only being used by those who call the middleware manually.

Yeah, we don't use this internally, this is just for consumers of the middleware who happen to want to override options.

edmorley · 2017-09-30T23:53:50Z

packages/neutrino-preset-web/index.js

@@ -98,10 +95,6 @@ module.exports = (neutrino, opts = {}) => {
      .chunkFilename('[name].[chunkhash].js')
      .end()
    .resolve
-      .alias
-        // Make sure 2 versions of "core-js" always match in package.json and babel-polyfill/package.json
-        .set('core-js', dirname(require.resolve('core-js')))


I just spotted core-js is now unused after this and can be removed from package.json

Good catch.

edmorley · 2017-09-30T23:55:15Z

packages/neutrino-preset-web/polyfills.js

@@ -1 +0,0 @@
-import 'babel-polyfill';


The babel-polyfill package is now unused too and can be removed from package.json

Definitely, good catch.

I've opened #339 to remove the unused deps

Addresses: #315 (comment)

* Move preset-airbnb-base dependencies out of middleware-eslint The `eslint-config-airbnb-base` and `eslint-plugin-import` packages are not used by `neutrino-middleware-eslint` itself, but instead by `neutrino-preset-airbnb-base`. * Remove unused dependencies Of note: * `webpack-dev-middleware` can be removed from the karma preset, since it's only used by `karma-webpack` which already has it as a dependency. * `webpack-dev-server` can be removed from the web preset since it's a leftover from when `neutrino-middleware-dev-server` was created. * the web preset's `core-js` and `babel-polyfill` dependencies are leftover from #315. Everything else was manually determined to be unused via correlating the package list against greps of the source, plus checking that the package wasn't a peer dependency of another listed package. * Regenerate yarn lockfiles

See: #315 (comment) Also restores the best practices of using `-f` with curl, as well as quietening the log spam.

Previously if `exclude` was set manually, it would prevent the default value for `include` being used. Now consumers of the middleware can pass just `exclude` and not have to pass both. See: #315 (comment) The default include in neutrino-preset-airbnb-base has also been removed, since it just duplicated that in neutrino-middleware-eslint.

Since the option was removed in #315.

Support for the preset option `polyfills.babel` was removed in #315 (Neutrino 7), leaving just `polyfills.async` which was removed in #790.

eliperelman changed the title ~~Upgrading Webpack to v3, exclusionary .neutrinorc.js, merge config as middleware~~ Upgrading Webpack to v3, merge config as middleware Sep 13, 2017

eliperelman added 25 commits September 28, 2017 10:43

Upgrading Webpack to v3, exlusionary .neutrinorc.js, merge config as …

090cdeb

…middleware

Documentation updates

abf05cc

Removing remaining uses of options.static

7e2cf33

Document Neutrino event mechanisms

87d40fd

Lock yarn to oao-compatible version

fecdfea

Updating webpack-chain and other external depenencies

ea52d5d

Switch babel merging out for babel-merge package

0a3796e

Adding docs for babel configuration merging for compile loader

ce79701

Be explicit about letting certain build features run in certain envir…

8f4ea0f

…onments

Updating plugin environments and command execution

dd82094

Module concatenation plugin

c04b6ba

Removing babel-polyfill as a default entry

48a35e0

Switch to BabelMinifyWebpackPlugin

80b9234

Remove default webpack node options

c6f361f

Docs about minify breaking change

c3b58f1

Allow middleware to be reused by allowing option for usage IDs

1a52248

Add feature for --require

483b9ad

Run env middleware against process.env as well as api.options.env

0450a5b

Upgrading dependencies again

6a87a3d

Remove configured externals in react preset for React 16

cd30687

Document options.command

f9bcc6f

Switching svg loader from file to url

15199a2

Update webpack-chain docs from @emorley

bf8b7d1

Revert svg loader breaking change docs

fb15c86

Post-rebase yarn.lock updates

a9261b7

eliperelman merged commit 3d7ea84 into neutrinojs:master Sep 28, 2017

edmorley reviewed Sep 29, 2017

View reviewed changes

edmorley reviewed Oct 1, 2017

View reviewed changes

This was referenced Oct 2, 2017

Remove unused dependencies #339

Merged

Fix link to babel-minify-webpack-plugin options #340

Merged

edmorley added a commit that referenced this pull request Oct 2, 2017

Fix link to babel-minify-webpack-plugin options (#340)

703da77

Addresses: #315 (comment)

This was referenced Oct 5, 2017

Travis: Document the pinned version of yarn #343

Merged

Preserve ESLint default include when just exclude set #344

Merged

eliperelman pushed a commit that referenced this pull request Oct 6, 2017

Travis: Document the pinned version of yarn (#343)

dec7201

See: #315 (comment) Also restores the best practices of using `-f` with curl, as well as quietening the log spam.

edmorley mentioned this pull request Nov 8, 2017

Docs: Remove leftover babel-polyfill references #419

Merged

eliperelman pushed a commit that referenced this pull request Nov 8, 2017

Docs: Remove leftover babel-polyfill references (#419)

1aa7f53

Since the option was removed in #315.

edmorley mentioned this pull request Sep 13, 2018

Make removal of the 'polyfills' option more obvious #1099

Merged

edmorley added a commit that referenced this pull request Sep 14, 2018

Make removal of the 'polyfills' option more obvious (#1099)

f128f6f

Support for the preset option `polyfills.babel` was removed in #315 (Neutrino 7), leaving just `polyfills.async` which was removed in #790.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrading Webpack to v3, merge config as middleware #315

Upgrading Webpack to v3, merge config as middleware #315

eliperelman commented Sep 12, 2017

edmorley commented Sep 28, 2017

edmorley left a comment

edmorley Sep 29, 2017

edmorley Oct 2, 2017

edmorley Sep 29, 2017

edmorley Sep 29, 2017

eliperelman Oct 2, 2017

edmorley Sep 29, 2017

edmorley Sep 29, 2017

edmorley Sep 29, 2017

eliperelman Oct 2, 2017

edmorley Sep 29, 2017

eliperelman Oct 2, 2017

edmorley Oct 2, 2017

edmorley Sep 29, 2017

edmorley Sep 29, 2017

eliperelman Oct 2, 2017

edmorley Sep 29, 2017

eliperelman Oct 2, 2017

edmorley Sep 30, 2017

eliperelman Oct 2, 2017

edmorley Sep 30, 2017

eliperelman Oct 2, 2017

edmorley Oct 2, 2017

		@@ -3,18 +3,17 @@ const merge = require('deepmerge');
		module.exports = ({ config }, options = {}) => {
		const { limit } = merge({ limit: 8192 }, options);

Upgrading Webpack to v3, merge config as middleware #315

Upgrading Webpack to v3, merge config as middleware #315

Conversation

eliperelman commented Sep 12, 2017

edmorley commented Sep 28, 2017

edmorley left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment