This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Output logging messages when using watch instead of devServer #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
reviewed
Oct 25, 2017
packages/neutrino/bin/start.js
Outdated
| @@ -33,6 +33,13 @@ module.exports = (middleware, args) => { | |||
|
|
|||
| if (!compiler.options.devServer) { | |||
| spinner.succeed('Build completed'); | |||
| const building = ora('Source changed, re-compiling'); | |||
There was a problem hiding this comment.
Should this say "Waiting for initial build to finish" or similar, instead?
There was a problem hiding this comment.
Or "Performing initial build" etc
|
Updated. |
edmorley
approved these changes
Oct 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #375.
So, incremental building actually works, it just doesn't show a new console message every time like the dev server currently does. This PR should fix that.