This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Allow usage of multiple same plugins, map mains to html plugins #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmorley
reviewed
Dec 4, 2017
| neutrino.use(htmlTemplate, merge({ | ||
| pluginId: `html-${key}`, | ||
| filename: `${key}.html`, | ||
| chunks: [key, 'vendor', 'runtime'] |
There was a problem hiding this comment.
Could you add a comment here and to packages/chunk/index.js saying the two sets of chunk names need to be kept in sync?
| @@ -340,7 +339,7 @@ _Note: Some plugins are only available in certain environments. To override them | |||
| | `env` | Inject environment variables into source code at `process.env`, defaults to only inject `NODE_ENV`. From `@neutrinojs/env`. | all | | |||
| | `extract` | Extracts CSS from JS bundle into a separate stylesheet file. From `@neutrinojs/style-loader`. | all | | |||
| | `extract-modules` | Extracts CSS from JS bundle into a separate stylesheet file. From `@neutrinojs/style-loader`. | all | | |||
| | `html` | Automatically generates HTML files for configured entry points. From `@neutrinojs/html-template` | all | | |||
| | `html-{MAIN_NAME}` | Automatically generates HTML files for configured entry points. `{MAIN_NAME}` corresponds to the entry point of each page. By default, there is only a single `index` main, so this would generate a plugin named `html-index`. From `@neutrinojs/html-template` | all | | |||
There was a problem hiding this comment.
Good idea on making this breaking change, I think it will result in much less confusion long term for different naming forms for single and multi mains projects.
|
@eliperelman something's not right here…in Looking at the changes here, it indeed appears that |
|
@timkelty yikes, great catch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326.
This is a breaking change because it removes the
htmlplugin from the web preset and replaces it withhtml-index.