Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fix broken regex #604

Merged
merged 2 commits into from
Dec 13, 2017
Merged

Fix broken regex #604

merged 2 commits into from
Dec 13, 2017

Conversation

timkelty
Copy link
Contributor

@timkelty timkelty commented Dec 12, 2017

Almost lost my mind trying to figure out why .scss were importing without adding a test…

Easy to see why this got missed, as eslint warns of a "useless" escape inside a template literal, but being a regex string, it has meaning.

@timkelty timkelty added the bug label Dec 12, 2017
Copy link
Member

@eliperelman eliperelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! At first I couldn't find what the issue was, but the real issue here is that the regular expression is missing the backslash before the extension dot.

@eliperelman
Copy link
Member

🎉

@eliperelman eliperelman merged commit db16011 into master Dec 13, 2017
@edmorley edmorley deleted the fix-extension-regex branch December 19, 2017 17:24
timkelty added a commit to timkelty/neutrino that referenced this pull request Jan 17, 2018
* Fix broken regex

* String.raw tag fn
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

2 participants