Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

populate DRI2InfoRec driverNames #216

Merged
merged 2 commits into from
Mar 28, 2022
Merged

populate DRI2InfoRec driverNames #216

merged 2 commits into from
Mar 28, 2022

Conversation

akarl10
Copy link
Contributor

@akarl10 akarl10 commented Mar 25, 2022

#215

Currently needed for VDPAU with intel GPU
Borrowed from xorg modesetting display driver

Currently needed for VDPAU with intel GPU
Borrowed from xorg modesetting display driver
@Nexarian
Copy link
Contributor

@jsorg71 What do you think?

@jsorg71
Copy link
Contributor

jsorg71 commented Mar 27, 2022

The coding style is a bit off but I think because modesetting does this, it right.

@jsorg71
Copy link
Contributor

jsorg71 commented Mar 27, 2022

I see the latest also includes crocus, although I'm not sure what that is.

        if (strcmp(driver_names[0], "i965") == 0 ||
            strcmp(driver_names[0], "iris") == 0 ||
            strcmp(driver_names[0], "crocus") == 0) {
            driver_names[1] = "va_gl";
        } else {
            driver_names[1] = driver_names[0];
        }

@akarl10
Copy link
Contributor Author

akarl10 commented Mar 27, 2022

I see the latest also includes crocus, although I'm not sure what that is.

        if (strcmp(driver_names[0], "i965") == 0 ||
            strcmp(driver_names[0], "iris") == 0 ||
            strcmp(driver_names[0], "crocus") == 0) {
            driver_names[1] = "va_gl";
        } else {
            driver_names[1] = driver_names[0];
        }

You are right. Seems my source was not on the latest version.
https://gitlab.freedesktop.org/xorg/xserver/-/commit/a7b0a7fabd137183cc42a5edb15697e354c4450c

I will include this change.

About the coding style: it is, as mentioned in the comment, a copy of modesetting's dri.c

also change a bit of formatting to match better xorgxrdp
@Nexarian
Copy link
Contributor

@matt335672 @metalefty I'm OK with this change as it seems Jay is. As we integrate GFX it will definitely need to be updated, but this is a win for now.

@matt335672 matt335672 merged commit ad5f3c8 into neutrinolabs:devel Mar 28, 2022
@matt335672 matt335672 mentioned this pull request Mar 30, 2022
@matt335672
Copy link
Member

@paravz @akarl10 - see also #219 which should prevent this in the future.

@akarl10
Copy link
Contributor Author

akarl10 commented Mar 30, 2022

@paravz @akarl10 - see also #219 which should prevent this in the future.

👍 Makes definitely sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants