-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable touchpad inertial scrolling(fix touchpad scrolls too fast) #234
Conversation
Thanks, CI is failing but that's fine. This PR depends on neutrinolabs/xrdp#2364. |
This reverts commit 6e136ac8ffb4fdeba5e610bd2475d1db59175611.
@metalefty I've rebased the codes. Since the driver functions have been added. I deleted those hack codes at the same time. BTW: Is there any tool or coding style guidance to pass the CI code style check? |
Hi @seflerZ coding standard is on the wiki. Alternatively, there's a script run_astyle.sh in the xrdp/scripts directory that formats all your code for you using the I can see that this PR won't compile until neutrinolabs/xrdp#2364 is merged. Hope that's useful. |
@matt335672 Got it. I've fixed the code style issues in neutrinolabs/xrdp#2364. |
@metalefty - I'm unable to re-run the CI checks on this PR for some reason. Can you? |
Re-ran CI jobs. |
LGTM. @metalefty? |
LGTM, too. |
Thanks for code review. @metalefty & @matt335672 |
starting from which release version is this fix included in xrdp? |
Close #150 @metalefty
The xrdpMouse module doesn't handle touchpad inertial scrolling properly. At first I was intented to write a touchpad driver, now I found it uncessary. Because the RDP protocol doesn't have a touchpad channel, it should be good to add some touchpad function in the xrdpMouse driver.
Now the scrolling works great both on vertical and horizontal scrollings. Inertial scrolling also supported.
Note: Some applications such as Firefox which uses WebKitGTK, have their own inertial handling process, so it won't work on every applications.