Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expedition Loots Balance Pass (Again) #1821

Merged
merged 30 commits into from
Aug 15, 2024

Conversation

ErhardSteinhauer
Copy link
Contributor

@ErhardSteinhauer ErhardSteinhauer commented Aug 8, 2024

About the PR

Changes so far:

  • Diluted weapon loot pools with ammo boxes. Added sprites for ammo and explosives cases, ammo crates.
  • Increased likelihood of spawning of higher tier weapons in dungeon vaults by 5% (10% -> 15%).
  • Added more crates with loot to departmental themed crate spawners.
  • Added sprites for mercenary, private security and firearms crates.
  • Doubled the sell price for vendomat restock boxes: 200 -> 400.
  • Moved files around.

Why / Balance

Too many guns, too many flatpacks.

How to test

  1. Run dungen command and inspects crates. There should be less guns or crates with flatpacks for entire lab/factory.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog
🆑 erhardsteinhauer

  • add: Added ammo crates and cases to expedition loot pools: weapons should become slightly less common, however probability of getting better weapons were increased (slightly).
  • tweak: Doubled the sell price for vendor restock boxes: 200 -> 400.

Copy link
Contributor

github-actions bot commented Aug 8, 2024

RSI Diff Bot; head commit d5b2c4c merging into 646f39b
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Objects/Storage/Cases/ammocaseshort.rsi

State Old New Status
icon-open Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Objects/Storage/Cases/explosivescaseshort.rsi

State Old New Status
icon-open Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/_NF/Objects/Storage/Cases/guncaselong.rsi

State Old New Status
unshaded Added

Resources/Textures/_NF/Objects/Storage/Cases/guncaseshort.rsi

State Old New Status
unshaded Added

Resources/Textures/_NF/Structures/Storage/Crates/ammo.rsi

State Old New Status
base Added
closed Added
icon Added
open Added
welded Added

Resources/Textures/_NF/Structures/Storage/Crates/secure_ammo.rsi

State Old New Status
base Added
closed Added
icon Added
locked Added
open Added
sparks Added
unlocked Added
welded Added

Resources/Textures/_NF/Structures/Storage/Crates/secure_firearms.rsi

State Old New Status
base Added
closed Added
icon Added
locked Added
open Added
sparking Added
unlocked Added
welded Added

Resources/Textures/_NF/Structures/Storage/Crates/secure_mercenary.rsi

State Old New Status
base Added
closed Added
icon Added
locked Added
open Added
sparking Added
unlocked Added
welded Added

Resources/Textures/_NF/Structures/Storage/Crates/secure_privatesec.rsi

State Old New Status
base Added
closed Added
icon Added
locked Added
open Added
sparking Added
unlocked Added
welded Added

Edit: diff updated after d5b2c4c

@ErhardSteinhauer ErhardSteinhauer marked this pull request as ready for review August 9, 2024 17:21
@ErhardSteinhauer ErhardSteinhauer requested review from dvir001 and whatston3 and removed request for dvir001 August 9, 2024 17:22
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Aug 9, 2024
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, can't think of anything else to add.

@ErhardSteinhauer ErhardSteinhauer mentioned this pull request Aug 13, 2024
4 tasks
Copy link
Contributor

@whatston3 whatston3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over this again, newest changes seem good.

@whatston3 whatston3 merged commit de0045d into new-frontiers-14:master Aug 15, 2024
14 checks passed
FrontierATC added a commit that referenced this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants