Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DungeonJob.PostGenWallMount: better error handling #1858

Conversation

whatston3
Copy link
Contributor

About the PR

Added error checks to dungen wallmount jobs to avoid throwing exceptions.

Why / Balance

Dungeon generation was failing, and this caused expedition computers to get stuck.

As a note, the Mineshaft expeditions seem terrible, they're open corridors in something that may not be entirely rock.

How to test

  1. Buy an expedition ship.
  2. Go on an expedition to a Caves biome (more likely to have Haunted, Mineshaft expedition types).
  3. The expedition should go through, you should warp as normal and not get stuck.
  4. Repeat steps 2-4 until satisfied.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • fix: An issue causing salvage expedition consoles to get stuck has been resolved.

@github-actions github-actions bot added the C# label Aug 13, 2024
@dvir001 dvir001 self-requested a review August 14, 2024 08:55
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Aug 14, 2024
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DIdnt test in game yet but the code change looks sane.

@whatston3
Copy link
Contributor Author

Somewhat related - while we're editing dungeon generation stuff, we could add WallRock walls to the mineshaft definition variants so they aren't just out and open. Should make the thing more believable/less scuffed at the very least.

@ErhardSteinhauer ErhardSteinhauer merged commit 2952598 into new-frontiers-14:master Aug 15, 2024
11 checks passed
FrontierATC added a commit that referenced this pull request Aug 15, 2024
@whatston3 whatston3 deleted the 2024-08-13-expedition-wallmount-check branch September 21, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants