Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo Sell - fix order of checks, no selling station pets. #2354

Merged
merged 3 commits into from
Nov 1, 2024

Conversation

whatston3
Copy link
Contributor

About the PR

Changes the order of checks in CargoSystem.CanSell, removing the "return true" for dead mobs. Critical mobs are now not sellable.

Pun Pun, Yip Yip, and the station cats are now blacklisted for sale at cargo (Cappy's bounty is still valid).

Why / Balance

Abusable.

How to test

Media

Requirements

Breaking changes

Changelog

🆑

  • tweak: Critical mobs can no longer be sold.

@dvir001 dvir001 self-requested a review November 1, 2024 15:58
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Nov 1, 2024
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bug fix

@dvir001 dvir001 merged commit fef1639 into new-frontiers-14:master Nov 1, 2024
16 checks passed
FrontierATC added a commit that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants