North Pole Directional Fans #2368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tbh the whole danged POI could probably get a touch up. the large diff is likely because of entirely new map formats, etc., but its about that time of year to enable it again. |
Probably, but not in the scope of this specific PR; if not merged, I'd be fine with closing this if said touch-up is in the works.
Yes and no...? MetaData and AtmosDevice components seem to make up the bulk (if not all) of it; otherwise, nothing is changed (besides the fans themselves, of course). |
|
Looks fine, a bit late but here we go |
dvir001
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Purged Tiny Fans for Directional Fans.
Why / Balance
Directional fan good.
How to test
Requirements