Raise DroppedEvent on items in pockets/suit storage. #2400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Raises a DroppedEvent on all items in dependent inventory slot when unequipping its parent.
Why / Balance
When removing a piece of clothing in an outer slot, the dependent slots' contents (e.g. pockets, suit storage, belt) would not raise a DroppedEvent. Some items (jetpacks, health scanners, etc.) rely on this event to cut down on bookkeeping or maintain state.
Fixes https://discord.com/channels/1123826877245694004/1305455935216549940.
Issues
This fix depends on some existing behaviour - all existing code that raises DroppedEvent removing items from slots through interaction or the like only interacts with the item being dropped directly, ignoring any children (which it doesn't know about from the call). The contents of dependent slots are only removed and relocated without any event.
How to test
Media
Requirements
Breaking changes
Changelog
Minor fix, difficult to describe to players, no changelog.