Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuckleSystem: stop setting every interaction as handled #2538

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

whatston3
Copy link
Contributor

About the PR

Sets handled to handled when an event is handled.

Why / Balance

When clicking to interact with, say, a mothroach, to pick it up - for whatever reason, the BuckleSystem has priority, and sets all interactions as handled.

Jesus Christ.

How to test

  1. Checkout master.
  2. Spawn mothroach.
  3. Click mothroach. Nothing happens. HMMMM.
  4. Checkout this branch.
  5. Spawn mothroach.
  6. Click mothroach. Pick it up. All is well.

Media

Safely in hand.
image

Requirements

Breaking changes

Changelog

🆑

  • fix: Clicking on mobs should pick them up, pet them, or otherwise interact as normal.

@github-actions github-actions bot added the C# label Dec 10, 2024
@Havaren
Copy link

Havaren commented Dec 10, 2024

thank you.

@dvir001 dvir001 self-requested a review December 10, 2024 14:45
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Dec 10, 2024
@dvir001 dvir001 merged commit 46c8438 into new-frontiers-14:master Dec 10, 2024
11 checks passed
FrontierATC added a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants