Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SalvageMobRestrictions: no warning/logging for safe mobs (e.g. Clugg) #2552

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

whatston3
Copy link
Contributor

About the PR

When a mob leaves its restricted grid, if the mob will not be destroyed when leaving (i.e. it's a safe mob that spawns in with a bluespace event), it will not be warned or leave an admin log if leaving the grid.

Why / Balance

Oversight in #2449.

How to test

  1. Run addgamerule BluespaceCave.
  2. Become Clugg.
  3. Leave the grid. You shouldn't get a popup.
  4. Return to the grid.
  5. Spawn in and become a Xeno queen.
  6. Leave the grid. You should get a popup and turn pacified.
  7. Return to the grid. No more pacifism.
  8. Check the admin logs, you should have nothing from Clugg, and messages about the xeno queen leaving.

Media

Step 6: the xeno queen leaves the grid it's attached to, and is prompted to return.
image

Requirements

Breaking changes

Changelog

🆑

  • fix: Clugg is no longer prompted to return to the cave if leaving.

@github-actions github-actions bot added Map-Shuttle Map - Shuttle Map-POI Map - POI Map-Dungeon Map - Dungeon C# labels Dec 12, 2024
@whatston3
Copy link
Contributor Author

whatston3 commented Dec 12, 2024

Oops. Hold on.
Edit: fixed.

@whatston3 whatston3 removed Map-Shuttle Map - Shuttle Map-POI Map - POI Map-Dungeon Map - Dungeon labels Dec 12, 2024
@dvir001 dvir001 self-requested a review December 12, 2024 01:28
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Dec 12, 2024
@whatston3
Copy link
Contributor Author

Merging this as a hotfix - seemed fine in local testing.

@whatston3 whatston3 merged commit ce71708 into new-frontiers-14:master Dec 12, 2024
12 checks passed
FrontierATC added a commit that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# Status: Needs Review This PR is awaiting reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants