Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GPS app to pirate PDAs #2617

Merged
merged 4 commits into from
Dec 26, 2024
Merged

Add GPS app to pirate PDAs #2617

merged 4 commits into from
Dec 26, 2024

Conversation

Bonaout
Copy link
Contributor

@Bonaout Bonaout commented Dec 26, 2024 •
edited by dvir001
Loading

About the PR

Added the AstroNav program on pirate PDAs !

Why / Balance

Pirate players tend to get lost in space with no ability to find where they are!

How to test

  • Spawn as a pirate/pirate first mate/pirate captain
  • Take the PDA in hand to check if the coordinates are shown on the held item interface
  • Open the Programs tab to check if the AstroNav program is installed

Media

piratepda1

Requirements

Breaking changes

Changelog
🆑

  • tweak: Pirate PDAs now have the AstroNav program

@dvir001
Copy link
Contributor

dvir001 commented Dec 26, 2024 •
edited
Loading

Frontier notes required as per all added lines.

Please edit the parent
image

@dvir001 dvir001 added the Status: Awaiting Changes This PR has changes that need to be made before merging label Dec 26, 2024
@Bonaout
Copy link
Contributor Author

Bonaout commented Dec 26, 2024

Something like this ?

@dvir001 dvir001 removed the Status: Awaiting Changes This PR has changes that need to be made before merging label Dec 26, 2024
@dvir001 dvir001 self-requested a review December 26, 2024 20:56
@github-actions github-actions bot added the Status: Needs Review This PR is awaiting reviews label Dec 26, 2024
dvir001
dvir001 approved these changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@dvir001 dvir001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the note

@Bonaout
Copy link
Contributor Author

Bonaout commented Dec 26, 2024

Ohh, I see what you mean now! Thank you!

@dvir001 dvir001 merged commit 63a3083 into new-frontiers-14:master Dec 26, 2024
13 checks passed
FrontierATC added a commit that referenced this pull request Dec 26, 2024
@FrontierATC
Automatic Changelog (#2617)
e7f1ea7
@Bonaout Bonaout deleted the Pirate-PDA-GPS branch December 26, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvir001 dvir001 dvir001 approved these changes

Assignees
No one assigned
Labels
No C# Status: Needs Review This PR is awaiting reviews YML
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bonaout @dvir001