Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

コミットメッセージに ';' が含まれていてもPRが取得できるようにする #7

Merged
merged 1 commit into from
Feb 10, 2022
Merged

コミットメッセージに ';' が含まれていてもPRが取得できるようにする #7

merged 1 commit into from
Feb 10, 2022

Conversation

yskoht
Copy link

@yskoht yskoht commented Feb 9, 2022

@yskoht yskoht requested a review from skahack February 9, 2022 05:20
skahack
skahack reviewed Feb 9, 2022
View reviewed changes
src/git.ts
.sync("git", [
"log",
"--oneline",
"--pretty=hash<%h> ref<%D> message<%s> date<%cd>",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsonにできると分かりやすそうですが、ここjsonで出力できないですかね

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、もとのrepositoryがこの修正なんですね

skahack
skahack approved these changes Feb 9, 2022
View reviewed changes
Copy link

@skahack skahack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yskoht yskoht merged commit 3b35da3 into master Feb 10, 2022
@yskoht yskoht deleted the fix/listCommits branch February 10, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skahack skahack skahack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yskoht @skahack