Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change logging level for 8T rebalancing messages #276

Merged
merged 4 commits into from
Mar 12, 2021
Merged

Change logging level for 8T rebalancing messages #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7873fcc
Merge pull request #265 from newrelic/develop
nr-swilloughby Jan 11, 2021
df4d9c2
Update ROADMAP.md
jodeev Feb 8, 2021
e3a6dd6
Fixed issue #213 to lower logging level of spurious errors from 8T lo…
nr-swilloughby Mar 12, 2021
0a506ff
updated changelog
nr-swilloughby Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Unreleased

### Changes
* Changed logging level for messages resulting from Infinite Tracing load balancing operations which were previously logged as errors; now they are debugging messages. [#213](https://github.com/newrelic/go-agent/issues/213)

## 3.10.0

### New Features
Expand Down
2 changes: 1 addition & 1 deletion ROADMAP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ New Relic is moving toward OpenTelemetry. OpenTelemetry is a unified standard fo


## Roadmap
**The roadmap project is found [here](https://github.com/newrelic/go-agent/projects/1)**.
**The Go instrumentation roadmap project is found [here](https://github.com/orgs/newrelic/projects/24)**.

This roadmap project is broken down into the following sections:

Expand Down
19 changes: 16 additions & 3 deletions v3/newrelic/trace_observer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,9 +272,22 @@ func (to *gRPCtraceObserver) rcvResponses(spanClient v1.IngestService_RecordSpan
for {
s, err := spanClient.Recv()
if nil != err {
to.log.Error("trace observer response error", map[string]interface{}{
"err": err.Error(),
})
// (issue 213) These two specific errors were reported as nuisance
// but are really harmless so we'll report them as DEBUG level events
// instead of ERROR.
// This error comes from our Infinite Tracing load balancers.
// We believe the EOF error comes from the gRPC getting reset every 30 seconds
// from the same cause (rebalancing 8T)
if err.Error() == "rpc error: code = Internal desc = stream terminated by RST_STREAM with error code: NO_ERROR" || err.Error() == "EOF" {
to.log.Debug("trace observer response error", map[string]interface{}{
"err": err.Error(),
})
} else {
to.log.Error("trace observer response error", map[string]interface{}{
"err": err.Error(),
})
}

// NOTE: even when the trace observer is shutting down
// properly, an EOF error will be received here and a
// supportability metric created.
Expand Down