More Defensive zerologWriter parsing #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nr-swilloughby
previously approved these changes
Sep 22, 2022
iamemilio
force-pushed
the
sqlFix
branch
3 times, most recently
from
7612ed7
to
ee3c1dc
Compare
nr-swilloughby
previously approved these changes
Oct 11, 2022
In preparation for a more feature rich log data spec, this parser was built to be able to scan additional contextual vaule from a zerolog log message. This patch fixes a bug where it was unable to correctly parse the JSON value for strings with commas,numbers, or stack traces.
nr-swilloughby
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for a more feature rich log data spec, this parser was built to be able to scan additional contextual vaule from a zerolog log message. This patch fixes a bug where it was unable to correctly parse the JSON value for strings with commas, numbers, or stack traces.