Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added checks for the presence of the security agent before calling se… #756

Merged
merged 1 commit into from
Jul 31, 2023
Merged

added checks for the presence of the security agent before calling se… #756

merged 1 commit into from
Jul 31, 2023

Conversation

nr-swilloughby
Copy link
Contributor

Since the fix to the race condition mentioned in PR 754 needs to lock and unlock a Transaction mutex each time a segment is created, this PR adds a check first so that if there is no security agent installed at all, we don't attempt the security call at all, removing the race condition and mutex overhead in that case. If a security agent is installed, then the mutex-protected code will be used to prevent the race condition.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2023

Codecov Report

❗ No coverage uploaded for pull request base (develop@99f46e0). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #756   +/-   ##
==========================================
  Coverage           ?   82.33%           
==========================================
  Files              ?      136           
  Lines              ?    12187           
  Branches           ?        0           
==========================================
  Hits               ?    10034           
  Misses             ?     1893           
  Partials           ?      260           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nr-swilloughby nr-swilloughby merged commit f405526 into newrelic:develop Jul 31, 2023
47 checks passed
@nr-swilloughby nr-swilloughby deleted the data_race_issue_addendum branch July 31, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants