-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMQP DT support for New Relic #780
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #780 +/- ##
===========================================
- Coverage 81.38% 81.06% -0.32%
===========================================
Files 134 135 +1
Lines 12353 12376 +23
===========================================
- Hits 10053 10033 -20
- Misses 2014 2059 +45
+ Partials 286 284 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Automatically instrument and collect distributed traces on AMQP/RabbitMQ code with the New Relic Go agent.
Ok, this is ready for a review. The AMQP tests will not pass because it requires a minimum version of the go agent in the go.mod that we have not yet released. It has to do this otherwise certain metric constants and attribute settings will not exist. |
Can you get the AMQP test to pass by temporarily adding a replace line in the go.mod to tell it to use the local code as the new version of the agent? Or is the issue deeper than that, and it really requires that the agent is released and identifies itself as the new version? |
Yeah, I can do that if you want. We should remember to take that out before releasing though |
Otherwise, and based on your demo yesterday, it looks good to me. |
Besides the minor naming thing I mentioned this also looks good :) |
what naming thing? |
clean up nramqp go.mod
My bad @iamemilio i forgot to publish the review :') |
No description provided.