AMQP DT support for New Relic

[iamemilio]

No description provided.

[codecov-commenter]

Codecov Report

Merging #780 (f896274) into develop (89f60a8) will decrease coverage by 0.32%.
Report is 4 commits behind head on develop.
The diff coverage is 47.32%.

@@             Coverage Diff             @@
##           develop     #780      +/-   ##
===========================================
- Coverage    81.38%   81.06%   -0.32%     
===========================================
  Files          134      135       +1     
  Lines        12353    12376      +23     
===========================================
- Hits         10053    10033      -20     
- Misses        2014     2059      +45     
+ Partials       286      284       -2     

Files	Coverage Δ
v3/newrelic/attributes_from_internal.go	94.98% <ø> (ø)
v3/newrelic/transaction.go	68.00% <ø> (ø)
v3/integrations/nramqp/headers.go	92.85% <92.85%> (ø)
v3/integrations/nramqp/nramqp.go	20.00% <20.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[iamemilio]

Ok, this is ready for a review. The AMQP tests will not pass because it requires a minimum version of the go agent in the go.mod that we have not yet released. It has to do this otherwise certain metric constants and attribute settings will not exist.

[nr-swilloughby]

Can you get the AMQP test to pass by temporarily adding a replace line in the go.mod to tell it to use the local code as the new version of the agent? Or is the issue deeper than that, and it really requires that the agent is released and identifies itself as the new version?

[iamemilio]

Can you get the AMQP test to pass by temporarily adding a replace line in the go.mod to tell it to use the local code as the new version of the agent? Or is the issue deeper than that, and it really requires that the agent is released and identifies itself as the new version?

Yeah, I can do that if you want. We should remember to take that out before releasing though

[nr-swilloughby]

Otherwise, and based on your demo yesterday, it looks good to me.

[mirackara]

Besides the minor naming thing I mentioned this also looks good :)

[iamemilio]

Besides the minor naming thing I mentioned this also looks good :)

what naming thing?

[mirackara]

My bad @iamemilio i forgot to publish the review :')