-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove all extraneous version constraints #940
remove all extraneous version constraints #940
Conversation
Hey @rittneje, can you rebase on develop. This commit is pulling in a lot of excess. |
e98a812
to
3dcea2b
Compare
@iamemilio done |
It looks like there is a stray commit still attached. Is it ok if we use this pull request containing your commit: #941? You are still credited on the commit, it just also lets me run it along side changes I just made to the test suite so that we can verify that go1.23rc runs as expected |
Oh, I am just noticing now that the protobuff changes went into master instead of develop, and that is whats causing this |
I can merge this here then, and I will rebase my commit on top. |
Thanks @rittneje |
Hi @iamemilio sorry for tagging you, This is an excerpt of what I got:
This page https://pkg.go.dev/google.golang.org/protobuf?tab=versions shows that |
I've made a PR that might resolve that, please help review it #948 :) |
Fixes #939.
As per the README, Go 1.18+ is already required. Thus version constraints for 1.9 and 1.10 are unnecessary. (And these currently cause issues with 1.23rc2 due to golang/go#68658.)