Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(depguard): we should disable it since it is not used anymore #15

Merged
merged 1 commit into from
Jun 6, 2023
Merged

fix(depguard): we should disable it since it is not used anymore #15

merged 1 commit into from
Jun 6, 2023

Conversation

paologallinaharbur
Copy link
Member

Disabled due to golangci/golangci-lint#3877

Depguard now expects a list of allow/deny list.

Then it's because you are using depguard without any configuration.
You have to either add a configuration or disable depguard.
The default rule of depguard is to allow only std lib in all files.

@paologallinaharbur paologallinaharbur requested a review from a team June 6, 2023 10:46
sigilioso
sigilioso approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@sigilioso sigilioso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@paologallinaharbur paologallinaharbur merged commit 4d20bdd into main Jun 6, 2023
@paologallinaharbur paologallinaharbur deleted the fix/disableDepguard branch June 6, 2023 13:28
@paologallinaharbur paologallinaharbur mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigilioso sigilioso sigilioso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paologallinaharbur @sigilioso