Merge pull request #19 from MrAlias/fix-tracing-rule

Fix the default tracing rule
newrelic · Feb 21, 2020 · e19ad57 · e19ad57
2 parents 9d223f1 + 7d25045
commit e19ad57
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 
 ## Unreleased
 
+### Fixed
+
+* The default tracing rule error for the incorrect parsed type in the rule expression is resolved. [#14](https://github.com/newrelic/newrelic-istio-adapter/issues/14)
+
 ## 2.0.1
 
 ### Added

diff --git a/helm-charts/values.yaml b/helm-charts/values.yaml
@@ -681,6 +681,6 @@ telemetry:
     ## The following can be uncommented if spans for inter-service communication
     ## should be sent to New Relic.
     #newrelic-tracing:
-    #  match: (context.protocol == "http" || context.protocol == "grpc") && destination.workload.name != "istio-telemetry" && destination.workload.name != "istio-pilot" && ((request.headers["x-b3-sampled"] | "0") == "1")
+    #  match: (context.protocol == "http" || context.protocol == "grpc") && destination.workload.name != "istio-telemetry" && destination.workload.name != "istio-pilot" && ((request.headers["x-b3-sampled"] | "") == "1")
     #  instances:
     #    - newrelic-span