CI: gemspec files test - bypass cache #2130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectively fork `Gem::Specification.load` to bypass its internal caching mechanism, and catch parse failures with an assertion.
When parsing `newrelic_rpm.gemspec` from a directory other than the project root, make sure that the `.build_ignore` file can be found by leveraging its absolute path
We were previously skipping the `rails<version>` env tests, but not the `norails` ones. Skip those too.
fallwith
requested review from
hannahramadan,
kaylareopelle and
tannalynn
as code owners
|
resolves #2117 |
fallwith
changed the title
SimpleCov Report
|
fallwith
changed the title
The automated CI tests only run the 'env' suites, so we can't skip `norails`. Instead, just chdir to the root of the agent dir, which is where any production targetting `gem build` process will take place.
kaylareopelle
approved these changes
Jul 11, 2023
Skip older Rubygems based contexts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to get the .gemspec test to work with our automated CI system:
Gem::Specification.loadto bypass its internal caching mechanismnewrelic_rpm.gemspecto use an absolute path to the.build_ignorefilechdirto the agent root for the evaluation of the .gemspec file