Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use double splat for Ruby >= 3.0 #2915

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

patrickarnett
Copy link
Contributor

@patrickarnett patrickarnett commented Oct 17, 2024

Overview

Kafka::Consumer#each_message takes keyword arguments. In Ruby >= 3.0, prepending it with a method that takes only positional arguments causes an ArgumentError when calling super.

Reviewer Checklist

  • Perform code review
  • Add performance label
  • Perform appropriate level of performance testing
  • Confirm all checks passed
  • Add version label prior to acceptance

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the community To tag external issues and PRs submitted by the community label Oct 17, 2024
Copy link
Contributor

@tannalynn tannalynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this update!
We did something similar for our rdkafka instrumentation but this one slid under the radar and I didn't realize this would happen. We appreciate the contribution!

@tannalynn tannalynn merged commit 677f136 into newrelic:dev Oct 21, 2024
31 checks passed
@gfmurphy
Copy link

@tannalynn any ideas on when this will land in a patch release? We recently ran into this when updating to 9.14.0. Thanks!

@tannalynn
Copy link
Contributor

@gfmurphy Thanks for checking in on this! We plan on releasing this fix later this week, as 9.15.0. Hopefully that helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community To tag external issues and PRs submitted by the community
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants