-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix javadocs for telemetry core #241
fix javadocs for telemetry core #241
Conversation
After this PR gets merged, I will work on the last one. |
@@ -22,6 +22,7 @@ | |||
* | |||
* @param eventType The type of event. | |||
* @param attributes The key-value pairs that make up the event. | |||
* @param timestamp time stamp in epoch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
millis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's just change that one timestamp to clarify units. Thanks again!
(Also needs a rebase) |
0799884
to
d63b5e1
Compare
d63b5e1
to
2141fbc
Compare
all done. ( : |
Thanks again @uaihebert ! |
fix #236