Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix telemetry-all and clean up build for consistency #242

Merged
merged 8 commits into from
Oct 6, 2020

Conversation

ysb33r
Copy link
Contributor

@ysb33r ysb33r commented Oct 2, 2020

  • FIxed telemetry-all to be a modular java build.
  • Cleaned up all subproject for consistent usage of versions.
  • Renamed telemetry_core to telemetry-core directories for consistency.
  • settings.gradle -> settings.gradle.kts

Copy link
Contributor

@kittylyst kittylyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚢

@ysb33r ysb33r force-pushed the schalk/fix-all-telemetry branch from 9561fbf to 2c9de45 Compare October 6, 2020 20:25
@ysb33r ysb33r changed the title Fix telemetry=all and clean up build for consistency Fix telemetry-all and clean up build for consistency Oct 6, 2020
Copy link
Contributor

@breedx-nr breedx-nr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ❤️ the telemetry_core -> telemetry-core thing, it's been driving me bonkers for so long now, heh. Thanks for taking this on.

@breedx-nr
Copy link
Contributor

A slightly risky merge given the fact that the build is reporting "internal failure", but I'm going to be bold and merge anyway and then troubleshoot.

@breedx-nr breedx-nr merged commit 52ee0e9 into newrelic:main Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants