Skip to content
This repository has been archived by the owner on Apr 21, 2020. It is now read-only.

Changing "inherits params" to "inherits ::newrelic::params" #39

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

systemsathomesdotcom
Copy link

also adding a basic Gemfile and a basic Debian test.

bundle install --without development
bundle exec rake spec SPEC_OPTS='--format documentation'

It may be useful to create a travisci job for this in the future.

also adding a basic Gemfile and a basic Debian test.

bundle install --without development
bundle exec rake spec SPEC_OPTS='--format documentation'
They should then be referenced from $::newrelic_plugin::var_name
instead of $::newrelic_plubin::params::varname.
@noqqe
Copy link

noqqe commented May 19, 2016

I would recommend to merge this. Otherwise you get funny errors and are not be able to run the newrelic_plugins module.

Error: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not find parent resource type '::params' of type hostclass in testenvironment at line 17 on node $host
Warning: Not using cache on failed catalog
Error: Could not retrieve catalog; skipping run

@joelesalas
Copy link

This is essential for anyone using Puppet >4 or the future parser.

@dmichel1
Copy link

dmichel1 commented Oct 3, 2017

Bump - Can someone at Newrelic take a look at this?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants