Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add linux node selector #1000

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Conversation

dbudziwojskiNR
Copy link
Contributor

@dbudziwojskiNR dbudziwojskiNR commented Feb 22, 2024

Description

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add changelog entry following the contributing guide
  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.15%. Comparing base (bc01167) to head (5833f5c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1000   +/-   ##
=======================================
  Coverage   70.15%   70.15%           
=======================================
  Files          46       46           
  Lines        3113     3113           
=======================================
  Hits         2184     2184           
  Misses        762      762           
  Partials      167      167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbudziwojskiNR dbudziwojskiNR marked this pull request as ready for review February 23, 2024 00:34
@dbudziwojskiNR dbudziwojskiNR requested a review from a team February 23, 2024 00:34
Copy link
Contributor

@csongnr csongnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm gj

@dbudziwojskiNR dbudziwojskiNR merged commit 659d1cf into main Feb 23, 2024
24 checks passed
@dbudziwojskiNR dbudziwojskiNR deleted the dbudziwojski/add-node-selector branch February 23, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants