fix(summary): summary "sum" metric must also be sent as delta #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to properly allow for average calculation, the "sum" attribute of the summary must also be delta
| Name: metric.name + "_sum", | ||
| Attributes: metric.attributes, | ||
| Count: 1, | ||
| Sum: sumCount.Value, |
There was a problem hiding this comment.
I would thought that this value already come in the original prometheus metric and we just need it to send it as it is.
There was a problem hiding this comment.
In prometheus it comes as a counter and so in order for us to be able to calculate the average (_sum/_count) we also need to send it as a delta, like we do for the _count
gsanchezgavier
approved these changes
Oct 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in order to properly allow for average calculation, the "sum" attribute of the summary must also be delta
fixes #100