Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default configs emitter and definition path #85

Merged
merged 3 commits into from
Oct 6, 2020
Merged

fix: default configs emitter and definition path #85

merged 3 commits into from
Oct 6, 2020

Conversation

gsanchezgavier
Copy link
Contributor

Adds default value for:

  • DefinitionFilesPath
  • Emitter: uses infra-sdk when standalone is false and telemetry when is true (backward compatibility)

This PR fixes issue #83

paologallinaharbur
paologallinaharbur previously approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@paologallinaharbur paologallinaharbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

paologallinaharbur
paologallinaharbur approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@paologallinaharbur paologallinaharbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes

@ardias ardias merged commit f84e4bf into main Oct 6, 2020
@ardias ardias deleted the gsanchez/fix_issue_83 branch October 6, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardias ardias ardias approved these changes

@paologallinaharbur paologallinaharbur paologallinaharbur approved these changes

@davidbrota davidbrota Awaiting requested review from davidbrota

@jorik jorik Awaiting requested review from jorik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsanchezgavier @ardias @paologallinaharbur