feat: accept duplicated service definitions #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paologallinaharbur
approved these changes
Oct 16, 2020
ardias
reviewed
Oct 16, 2020
| specs.SpecsByName[sd.Service] = sd | ||
| if spec, ok := specs.SpecsByName[sd.Service]; ok { | ||
| spec.Entities = append(spec.Entities, sd.Entities...) | ||
| specs.SpecsByName[sd.Service] = spec |
There was a problem hiding this comment.
just curiosity, do you have to re-assign the variable in the map? Wouldn't it be sufficient to just append the entities?
There was a problem hiding this comment.
It was complaining that it was possible , but I will dig into that
There was a problem hiding this comment.
It's because the map references to a value and not a pointer. And there's no guarantee on the location of that value.
https://stackoverflow.com/questions/32751537/why-do-i-get-a-cannot-assign-error-when-setting-value-to-a-struct-as-a-value-i
ardias
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows two exporter with same metric namespace to have different definition files .
This approach just adds the entities from all definitions files that share the same service name to the same object.
In the future the entity discovery mechanism should be replaced and this approach will no longer be needed.