Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kubernetes): Add gke autopilot check to script #1004

Merged
merged 10 commits into from
Dec 21, 2023

Conversation

svetlanabrennan
Copy link
Contributor

@svetlanabrennan svetlanabrennan commented Dec 15, 2023

Updating the script to check if user is installing in a GKE Autopilot. If they are, it will turn off privileged mode, control plane and then turn off pixie since it requires privileged access. It also turns off logging which is not currently supported in GKE autopilot.

@svetlanabrennan svetlanabrennan marked this pull request as ready for review December 20, 2023 23:53
csongnr
csongnr previously approved these changes Dec 21, 2023
Copy link
Member

@NSSPKrishna NSSPKrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me. Just a nit.

Co-authored-by: Prasanna Krishna <107837335+NSSPKrishna@users.noreply.github.com>
@amolero-nr amolero-nr merged commit 144a500 into main Dec 21, 2023
9 checks passed
@amolero-nr amolero-nr deleted the add-gke-autopilot-check branch December 21, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants