Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: remove agent type references (NR-337618) #1140

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

gsanchezgavier
Copy link
Contributor

Remove references from Agent types.

⚠️ It needs released changes on the SA. I'll notify whenever is ready

@gsanchezgavier gsanchezgavier marked this pull request as draft December 12, 2024 08:32
@gsanchezgavier gsanchezgavier changed the title [WIP] chore!: remove agent type references [WIP] chore!: remove agent type references (NR-337618) Dec 12, 2024
@gsanchezgavier gsanchezgavier requested a review from a team December 12, 2024 13:16
@gsanchezgavier gsanchezgavier marked this pull request as ready for review December 12, 2024 13:16
@gsanchezgavier gsanchezgavier changed the title [WIP] chore!: remove agent type references (NR-337618) chore!: remove agent type references (NR-337618) Dec 12, 2024
Copy link
Member

@paologallinaharbur paologallinaharbur Dec 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ It needs released changes on the SA. I'll notify whenever is ready

I'll try to release it today, however the changes will show agent-control and not super-agent 😕 I think you need to sync changes between @rubenruizdegauna and @DavSanchez

@gsanchezgavier gsanchezgavier force-pushed the gsanchez/fix/agent-type-ref branch from edb9025 to 53a5f1f Compare December 17, 2024 14:49
@gsanchezgavier gsanchezgavier changed the base branch from main to agent_control_renaming December 17, 2024 14:50
Copy link
Contributor

@rubenruizdegauna rubenruizdegauna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests will pass once the renaming is merged

@gsanchezgavier gsanchezgavier merged commit c9d69b2 into agent_control_renaming Dec 17, 2024
25 of 34 checks passed
@gsanchezgavier gsanchezgavier deleted the gsanchez/fix/agent-type-ref branch December 17, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants