fix: Snapshot makes shot even when its failed on specific functionality #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L0wry
reviewed
Mar 25, 2019
L0wry
reviewed
Mar 25, 2019
L0wry
reviewed
Mar 25, 2019
L0wry
reviewed
Mar 25, 2019
L0wry
reviewed
Mar 25, 2019
L0wry
previously requested changes
Mar 25, 2019
|
It would also be good to have an e2e test making sure that both the application exits when connection to grid fails + a wait fails but we still snap |
added 5 commits
April 16, 2019 14:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AyeSpy have special functionality : removeElements, hideElements, waitForElement, onReadyScript, ... and when its selector cannot be found snapshot is not available. This fix pretend this step and even selector is not defined correctly or missing on page which still goes to make shot of page and compare with Baseline.