Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use whatwg-url for creating urls in android #1326

Merged
merged 1 commit into from
Sep 14, 2018
Merged

fix: Use whatwg-url for creating urls in android #1326

merged 1 commit into from
Sep 14, 2018

Conversation

tuncaulubilge
Copy link
Contributor

React-native Android is overwriting URL class, which causes an error in our image component.

Applied the following fix to polyfill URL using whatwg-url: facebook/react-native#16434 (comment)

@tuncaulubilge tuncaulubilge changed the title Use whatwg-url for creating urls in android fix: Use whatwg-url for creating urls in android Sep 14, 2018
@times-tools
Copy link
Collaborator

Please find visual snapshots of your changed components here: https://s3-eu-west-1.amazonaws.com/times-components-snaps/c8d7eddadd4463af1696918c70398e740b859f73/index.html

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.778% when pulling c8d7edd on fix/android-image-url-polyfill into 276e9e8 on master.

@craigbilner craigbilner merged commit ac28429 into master Sep 14, 2018
@craigbilner craigbilner deleted the fix/android-image-url-polyfill branch September 14, 2018 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colincclark colincclark colincclark approved these changes

@jimhunty jimhunty jimhunty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tuncaulubilge @times-tools @coveralls @jimhunty @colincclark @craigbilner