Skip to content

Commit

Permalink
Stop testing CSS imports
Browse files Browse the repository at this point in the history
This behavior is deprecated in LibSass and is not supported in Dart
Sass. See sass/libsass#2611.
  • Loading branch information
nex3 committed Jun 1, 2018
1 parent 57e3e75 commit 89388db
Show file tree
Hide file tree
Showing 11 changed files with 1 addition and 36 deletions.
3 changes: 1 addition & 2 deletions test/index.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ implementations.forEach(implementation => {
it("should resolve imports from another directory declared by includePaths correctly", () => execTest("import-include-paths", {
includePaths: [path.join(__dirname, ext, "includePath")]
}));
it("should not resolve CSS imports", () => execTest("import-css"));
it("should compile bootstrap-sass without errors", () => execTest("bootstrap-sass"));
it("should correctly import scoped npm packages", () => execTest("import-from-npm-org-pkg"));
it("should resolve aliases", () => execTest("import-alias", {}, {
Expand Down Expand Up @@ -203,7 +202,7 @@ implementations.forEach(implementation => {
sourceMap.should.not.have.property("file");
sourceMap.should.have.property("sourceRoot", fakeCwd);
// This number needs to be updated if imports.scss or any dependency of that changes
sourceMap.sources.should.have.length(11);
sourceMap.sources.should.have.length(10);
sourceMap.sources.forEach(sourcePath =>
fs.existsSync(path.resolve(sourceMap.sourceRoot, sourcePath))
);
Expand Down
3 changes: 0 additions & 3 deletions test/node_modules/animate.css/animate.css

This file was deleted.

3 changes: 0 additions & 3 deletions test/node_modules/css/some-css-module.css

This file was deleted.

7 changes: 0 additions & 7 deletions test/sass/import-css.sass

This file was deleted.

1 change: 0 additions & 1 deletion test/sass/import-include-paths.sass
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
@import include-path-module
@import underscore-include-path-module
@import animate.css/animate
3 changes: 0 additions & 3 deletions test/sass/imports.sass
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@
// @see https://github.com/webpack-contrib/sass-loader/issues/167
/* @import ~sass/some.module */
@import ~sass/some.module
// @see https://github.com/webpack-contrib/sass-loader/issues/360
/* @import ~animate.css/animate */
@import ~animate.css/animate
/* @import url(http://example.com/something/from/the/interwebs); */
@import url(http://example.com/something/from/the/interwebs);
/* scoped import @import language */
Expand Down
3 changes: 0 additions & 3 deletions test/sass/includePath/animate.css/animate.css

This file was deleted.

7 changes: 0 additions & 7 deletions test/scss/import-css.scss

This file was deleted.

1 change: 0 additions & 1 deletion test/scss/import-include-paths.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,2 @@
@import "include-path-module";
@import "underscore-include-path-module";
@import "animate.css/animate";
3 changes: 0 additions & 3 deletions test/scss/imports.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@
// @see https://github.com/webpack-contrib/sass-loader/issues/167
/* @import "~scss/some.module"; */
@import "~scss/some.module";
// @see https://github.com/webpack-contrib/sass-loader/issues/360
/* @import "~animate.css/animate"; */
@import "~animate.css/animate";
/* @import url(http://example.com/something/from/the/interwebs); */
@import url(http://example.com/something/from/the/interwebs);
/* scoped import @import "language"; */
Expand Down
3 changes: 0 additions & 3 deletions test/scss/includePath/animate.css/animate.css

This file was deleted.

0 comments on commit 89388db

Please sign in to comment.